Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start the profiling server properly #4271

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Start the profiling server properly #4271

merged 1 commit into from
Oct 20, 2023

Conversation

eapolinario
Copy link
Contributor

Describe your changes

This PR fixes the initialization of the profiling server.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1c05db) 59.31% compared to head (d47e3f4) 59.64%.
Report is 1 commits behind head on master.

❗ Current head d47e3f4 differs from pull request most recent head 398ddf9. Consider uploading reports for the commit 398ddf9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4271      +/-   ##
==========================================
+ Coverage   59.31%   59.64%   +0.33%     
==========================================
  Files         623      553      -70     
  Lines       53394    40068   -13326     
==========================================
- Hits        31669    23899    -7770     
+ Misses      19204    13819    -5385     
+ Partials     2521     2350     -171     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 560 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit e2b1b0a into master Oct 20, 2023
39 of 40 checks passed
@eapolinario eapolinario deleted the fix-metrics-server branch October 20, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants