Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update k8s Dependencies" #4272

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

eapolinario
Copy link
Contributor

Reverts #4199

Quoting from my comment:

I'm reverting this temporarily just to get 1.10 out. The reason being that I don't want to ship these changes without (a lot) more testing.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 302 lines in your changes are missing coverage. Please review.

Comparison is base (e2b1b0a) 59.05% compared to head (09cabe9) 62.28%.

❗ Current head 09cabe9 differs from pull request most recent head e187ad3. Consider uploading reports for the commit e187ad3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4272      +/-   ##
==========================================
+ Coverage   59.05%   62.28%   +3.23%     
==========================================
  Files         614      391     -223     
  Lines       51998    28118   -23880     
==========================================
- Hits        30705    17512   -13193     
+ Misses      18842     8926    -9916     
+ Partials     2451     1680     -771     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ns/go/tasks/plugins/k8s/sagemaker/config/config.go 0.00% <0.00%> (ø)
...teplugins/go/tasks/plugins/k8s/sagemaker/plugin.go 74.07% <74.07%> (ø)
...o/tasks/plugins/k8s/sagemaker/plugin_test_utils.go 95.43% <95.43%> (ø)
...tasks/plugins/k8s/sagemaker/config/config_flags.go 24.00% <24.00%> (ø)
...eplugins/go/tasks/plugins/k8s/sagemaker/outputs.go 20.51% <20.51%> (ø)
.../go/tasks/plugins/k8s/sagemaker/custom_training.go 70.31% <70.31%> (ø)
...go/tasks/plugins/k8s/sagemaker/builtin_training.go 72.00% <72.00%> (ø)
...yteplugins/go/tasks/plugins/k8s/sagemaker/utils.go 71.54% <71.54%> (ø)
...sks/plugins/k8s/sagemaker/hyperparameter_tuning.go 60.45% <60.45%> (ø)

... and 595 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 6f02b4c into master Oct 20, 2023
40 checks passed
@eapolinario eapolinario deleted the revert-4199-update-k8s-dips branch October 20, 2023 20:12
eapolinario added a commit that referenced this pull request Oct 20, 2023
EngHabu pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants