flyteorg · EngHabu · Oct 10, 2023 · Oct 10, 2023 · Oct 11, 2023 · Oct 11, 2023
diff --git a/.github/workflows/single-binary.yml b/.github/workflows/single-binary.yml
@@ -199,6 +199,12 @@ jobs:
       - name: End2End
         run: |
           make end2end_execute
+      - name: Setup tmate session
+        uses: mxschmitt/action-tmate@v3
+        if: ${{ failure() }}
+        with:
+          limit-access-to-actor: true
+
 
   build-and-push-sandbox-bundled-image:
     if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}

diff --git a/.gitignore b/.gitignore
@@ -28,6 +28,8 @@ dist
 *.db
 vendor/
 /docker/sandbox-bundled/images/tar
+rsts/_tags/
+bin/
 **/bin/
 docs/_tags/
 docs/flytectl

diff --git a/Makefile b/Makefile
@@ -1,4 +1,5 @@
 export REPOSITORY=flyte
+export REPO_ROOT := $(shell pwd)
 include boilerplate/flyte/end2end/Makefile
 include boilerplate/flyte/golang_test_targets/Makefile
 
@@ -136,6 +137,15 @@ go-tidy:
 	make -C flytestdlib go-tidy
 	make -C flytecopilot go-tidy
 
+.PHONY: generate
+generate:
+	make -C flyteidl generate
+	make -C flyteadmin generate
+	make -C flytepropeller generate
+	make -C flyteplugins generate
+	make -C flytestdlib generate
+	make -C flytecopilot generate
+
 .PHONY: lint-helm-charts
 lint-helm-charts:
 	# This pressuposes that you have act installed

diff --git a/boilerplate/flyte/golang_test_targets/Makefile b/boilerplate/flyte/golang_test_targets/Makefile
@@ -4,10 +4,11 @@
 # TO OPT OUT OF UPDATES, SEE https://github.com/flyteorg/boilerplate/blob/master/Readme.rst
 
 LINT_FLAGS ?=
+export REPO_ROOT ?= $(shell pwd)
 
 .PHONY: download_tooling
 download_tooling: #download dependencies (including test deps) for the package
-	@../boilerplate/flyte/golang_test_targets/download_tooling.sh
+	@${REPO_ROOT}/boilerplate/flyte/golang_test_targets/download_tooling.sh
 
 .PHONY: generate
 generate: download_tooling #generate go code

diff --git a/boilerplate/flyte/golang_test_targets/download_tooling.sh b/boilerplate/flyte/golang_test_targets/download_tooling.sh
@@ -30,7 +30,7 @@ cp $REPO_ROOT/flytestdlib/bin/pflags $(go env GOPATH)/bin
 
 tmp_dir=$(mktemp -d -t gotooling-XXX)
 echo "Using temp directory ${tmp_dir}"
-cp -R ../boilerplate/flyte/golang_support_tools/* $tmp_dir
+cp -R $REPO_ROOT/boilerplate/flyte/golang_support_tools/* $tmp_dir
 pushd "$tmp_dir"
 
 for tool in "${tools[@]}"; do

diff --git a/cmd/single/config_flags.go b/cmd/single/config_flags.go
diff --git a/cmd/single/config_flags_test.go b/cmd/single/config_flags_test.go
diff --git a/cmd/single/without_console_dist.go b/cmd/single/without_console_dist.go
@@ -1,5 +1,4 @@
 //go:build !console
-// +build !console
 
 package single
 

diff --git a/datacatalog/Makefile b/datacatalog/Makefile
@@ -1,5 +1,5 @@
 export REPOSITORY=datacatalog
-export REPO_ROOT=..
+export REPO_ROOT ?= $(shell pwd)/../
 include ../boilerplate/flyte/docker_build/Makefile
 include ../boilerplate/flyte/golang_test_targets/Makefile
 

diff --git a/flyteadmin/Makefile b/flyteadmin/Makefile
@@ -1,6 +1,6 @@
 export REPOSITORY=flyteadmin
 export FLYTE_SCHEDULER_REPOSITORY=flytescheduler
-export REPO_ROOT=..
+export REPO_ROOT ?= $(shell pwd)/../
 include ../boilerplate/flyte/docker_build/Makefile
 include ../boilerplate/flyte/golang_test_targets/Makefile
 include ../boilerplate/flyte/end2end/Makefile