Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore deprecated NotificationsConfig.Region field #4299

Merged
merged 1 commit into from
Oct 25, 2023

Restore deprecated NotificationsConfig.Region field

20bb679
Select commit
Loading
Failed to load commit list.
Merged

Restore deprecated NotificationsConfig.Region field #4299

Restore deprecated NotificationsConfig.Region field
20bb679
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 25, 2023 in 1s

0.00% of diff hit (target 58.73%)

View this Pull Request on Codecov

0.00% of diff hit (target 58.73%)

Annotations

Check warning on line 71 in flyteadmin/pkg/async/notifications/factory.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/notifications/factory.go#L67-L71

Added lines #L67 - L71 were not covered by tests

Check warning on line 109 in flyteadmin/pkg/async/notifications/factory.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/async/notifications/factory.go#L105-L109

Added lines #L105 - L109 were not covered by tests