Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GetProject endpoint in FlyteAdmin #4316

Closed
wants to merge 8 commits into from

Conversation

RRap0so
Copy link
Contributor

@RRap0so RRap0so commented Oct 27, 2023

Tracking issue

Closes: #4317

Describe your changes

Add new GetProject enpoint to Flyteadmin

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

RRap0so and others added 4 commits October 27, 2023 09:35
Signed-off-by: Rafael Ribeiro Raposo <[email protected]>
Signed-off-by: Rafael Raposo <[email protected]>
Signed-off-by: Rafael Raposo <[email protected]>
@welcome
Copy link

welcome bot commented Oct 27, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (398e5cb) 59.03% compared to head (884df72) 59.90%.

❗ Current head 884df72 differs from pull request most recent head 5a44287. Consider uploading reports for the commit 5a44287 to get more accurate results

Files Patch % Lines
flyteadmin/pkg/rpc/adminservice/project.go 0.00% 13 Missing ⚠️
flyteadmin/pkg/manager/impl/project_manager.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4316      +/-   ##
==========================================
+ Coverage   59.03%   59.90%   +0.86%     
==========================================
  Files         622      562      -60     
  Lines       52682    40252   -12430     
==========================================
- Hits        31102    24112    -6990     
+ Misses      19098    13795    -5303     
+ Partials     2482     2345     -137     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 16, 2023
@RRap0so
Copy link
Contributor Author

RRap0so commented Feb 2, 2024

Replaced by #4825

@RRap0so RRap0so closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core feature] Implement GetProject endpoint in FlyteAdmin
1 participant