-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata in ArrayNode TaskExecutionEvents #4355
Conversation
Signed-off-by: Daniel Rammer <[email protected]>
…eadmin temporarily Signed-off-by: Daniel Rammer <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4355 +/- ##
==========================================
+ Coverage 59.10% 59.34% +0.24%
==========================================
Files 614 544 -70
Lines 52065 39003 -13062
==========================================
- Hits 30771 23146 -7625
+ Misses 18844 13575 -5269
+ Partials 2450 2282 -168
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
@@ -120,11 +120,39 @@ func (e *externalResourcesEventRecorder) finalize(ctx context.Context, nCtx inte | |||
OccurredAt: occurredAt, | |||
Metadata: &event.TaskExecutionMetadata{ | |||
ExternalResources: e.externalResources, | |||
PluginIdentifier: "container", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: why is not container_array
?
Tracking issue
NA
Describe your changes
Setting
PluginIdentifier
and Input and Output values.Check all the applicable boxes
Screenshots
NA
Note to reviewers
NA