-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence NotFound when get task resource #4388
Conversation
Signed-off-by: Hongxin Liang <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4388 +/- ##
==========================================
+ Coverage 59.59% 59.98% +0.39%
==========================================
Files 632 562 -70
Lines 53623 40291 -13332
==========================================
- Hits 31957 24169 -7788
+ Misses 19146 13772 -5374
+ Partials 2520 2350 -170
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Looks like flaky tests. The CI failure is not related to this change I believe. |
Signed-off-by: Hongxin Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great catch and thanks for the PR! A few nits, mostly my import organization OCD .. we should really automate this soon.
Signed-off-by: Hongxin Liang <[email protected]>
Tracking issue
Closes #4387
Docs link
Describe your changes
Do not issue warning log when the error is NotFound because that is in most cases intended.
Check all the applicable boxes
Setup Process
Screenshots
Note to reviewers
Related PRs