-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle all ray job statuses #4389
Conversation
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4389 +/- ##
==========================================
- Coverage 59.10% 57.97% -1.14%
==========================================
Files 614 396 -218
Lines 52103 29233 -22870
==========================================
- Hits 30797 16948 -13849
+ Misses 18853 10571 -8282
+ Partials 2453 1714 -739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -489,12 +489,18 @@ func (plugin rayJobResourceHandler) GetTaskPhase(ctx context.Context, pluginCont | |||
return pluginsCore.PhaseInfoFailure(flyteerr.TaskFailedWithError, reason, info), nil | |||
case rayv1alpha1.JobStatusSucceeded: | |||
return pluginsCore.PhaseInfoSuccess(info), nil | |||
case rayv1alpha1.JobStatusPending, rayv1alpha1.JobStatusRunning: | |||
case rayv1alpha1.JobStatusPending, rayv1alpha1.JobStatusRunning, rayv1alpha1.JobStatusStopped: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopped sounds weird to be running
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not currently being used in the operator... so I took a guess it's a temporary state (Succeeded/Failed are terminal)... hence why I marked it as Running. That said, I think it's ok for now to add it to the default handler of failing as an unknown/not handled state..
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Describe your changes
Ray operator sets a few different possible transient statuses as well as different cluster deployment statuses. The plugin doesn't handle all of them and silently attempts to make an illegal state transition instead of erroring. This change does two things:
Check all the applicable boxes