Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for displaying the Ray dashboard when a RayJob is active #4397

Merged
merged 11 commits into from
Nov 10, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Nov 10, 2023

Describe your changes

Depends on #4396.

  • Adds support for a TemplateLogPlugin for Ray dashboard that is added when the RayJob is in JobStatusRunning.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

#4396

@jeevb jeevb force-pushed the jeev/ray-dashboard branch from aad9450 to e0fc41a Compare November 10, 2023 01:26
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (09cb3b1) 58.13% compared to head (da041e5) 59.34%.

❗ Current head da041e5 differs from pull request most recent head cce822c. Consider uploading reports for the commit cce822c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4397      +/-   ##
==========================================
+ Coverage   58.13%   59.34%   +1.20%     
==========================================
  Files         466      544      +78     
  Lines       40047    38995    -1052     
==========================================
- Hits        23281    23140     -141     
+ Misses      14881    13570    -1311     
- Partials     1885     2285     +400     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteplugins/go/tasks/plugins/k8s/ray/config.go 36.36% <ø> (ø)
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 85.01% <78.94%> (ø)

... and 568 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EngHabu
EngHabu previously approved these changes Nov 10, 2023
@jeevb jeevb force-pushed the jeev/ray-dashboard branch from ec434a1 to ac2929e Compare November 10, 2023 06:57
Base automatically changed from jeev/refactor-logs to master November 10, 2023 19:14
@jeevb jeevb dismissed EngHabu’s stale review November 10, 2023 19:14

The base branch was changed.

@jeevb jeevb force-pushed the jeev/ray-dashboard branch from fbcdde1 to c1b49ab Compare November 10, 2023 19:15
@jeevb jeevb marked this pull request as ready for review November 10, 2023 19:17
@jeevb jeevb requested a review from EngHabu November 10, 2023 19:39
@jeevb jeevb merged commit 70c23c2 into master Nov 10, 2023
41 checks passed
@jeevb jeevb deleted the jeev/ray-dashboard branch November 10, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants