Add service monitor for flyte admin and propeller service

[vraiyaninv]

Describe your changes

Service monitors are a common way to auto-discover service targets dynamically in Prometheus.

This change allows the creation of a service monitor for the admin service as well as the creation of a service and service monitor for the propeller.

Propeller service allows discovering multiple instances of propeller pods and exporting its metrics.

Admin service monitor and propeller service as well as its service monitor are disabled by default

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

[welcome]

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

• Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
• Sign off your commits (Reference: DCO Guide).

[gdabisias]

Should this not be only enabled when serviceMonitor is enabled?

[vraiyaninv]

You can still have a service without servicemonitor so there is no harm in creating just the service. This keeps it flexible to have the service for any other ports which may not be related to prometheus port.

[gdabisias]

👍

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (956b24e) 59.81% compared to head (f77cd93) 59.82%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4427   +/-   ##
=======================================
  Coverage   59.81%   59.82%           
=======================================
  Files         632      632           
  Lines       53644    53644           
=======================================
+ Hits        32089    32091    +2     
+ Misses      19029    19028    -1     
+ Partials     2526     2525    -1     

Flag	Coverage Δ
unittests	59.82% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidmirror-ops]

Propeller service allows discovering multiple instances of propeller pods

This is particular to multi-cluster deployments correct?

[vraiyaninv]

Propeller service allows discovering multiple instances of propeller pods

This is particular to multi-cluster deployments correct?

It is for a single cluster, when you have multiple pods with propeller manager. We could have a pod monitor as well, but for uniformity across services, I leaned towards creating a service and having a service monitor.

[welcome]

Congrats on merging your first pull request! 🎉