Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyte webhooks #4431

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
1fb5f4b
wip
pingsutw May 19, 2023
0d4bfa6
wip
pingsutw May 19, 2023
513fbad
wip
pingsutw May 22, 2023
d334e49
wip
pingsutw May 23, 2023
d5a48f7
add log
pingsutw May 23, 2023
126f777
update webhook url
pingsutw May 23, 2023
cfc33fc
wip
pingsutw May 23, 2023
c5442dd
wip
pingsutw May 23, 2023
c75707a
wip
pingsutw May 23, 2023
a646c2f
wip
pingsutw May 23, 2023
d071e75
wip
pingsutw May 23, 2023
a37209f
wip
pingsutw May 24, 2023
e498539
wip
pingsutw May 24, 2023
bb05d3c
wip
pingsutw May 24, 2023
eccd859
wip
pingsutw May 24, 2023
31d11a4
wip
pingsutw May 24, 2023
c966a24
wip
pingsutw May 24, 2023
e0b14d2
webhook poc
pingsutw May 26, 2023
699adce
init
pingsutw Jun 21, 2023
1b3e896
nit
pingsutw Jun 21, 2023
206cefc
More tests
pingsutw Jun 21, 2023
83d7c3a
bump idl
pingsutw Jul 5, 2023
bb703aa
Merged master
pingsutw Jul 5, 2023
cd07b2a
nit
pingsutw Jul 5, 2023
4343654
nit
pingsutw Jul 6, 2023
96e663d
make generate
pingsutw Jul 6, 2023
6cee8cb
lint
pingsutw Jul 6, 2023
412f8cc
lint
pingsutw Jul 6, 2023
e9ab3cf
Merge branch 'master' of github.com:flyteorg/flyteadmin into webhook-v2
pingsutw Jul 19, 2023
99c39c0
Read webhook url from secret
pingsutw Jul 19, 2023
868ce14
add gcp processor
pingsutw Jul 20, 2023
fcfe202
lint
pingsutw Jul 21, 2023
6330314
Fixed tests
pingsutw Jul 21, 2023
d6d5343
nit
pingsutw Jul 21, 2023
a3828c8
lint
pingsutw Jul 21, 2023
0cd80f9
merged master
pingsutw Aug 14, 2023
b754cf8
bump idl
pingsutw Aug 21, 2023
25c3a0f
bump idl
pingsutw Aug 21, 2023
89fba4b
Transfer commits
eapolinario Oct 3, 2023
0f34110
init flyte webhook
pingsutw Nov 15, 2023
664c370
merged master
pingsutw Nov 15, 2023
3cd0cc0
update idl
pingsutw Nov 15, 2023
bcb4e89
fix compile
pingsutw Nov 15, 2023
70a28b3
fix-compile
pingsutw Nov 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
Signed-off-by: Kevin Su <[email protected]>
pingsutw committed Jul 6, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 6cee8cb83700c1b7c9de104e5a902625f3be061e
3 changes: 2 additions & 1 deletion flyteadmin/pkg/async/webhook/factory.go
Original file line number Diff line number Diff line change
@@ -3,9 +3,10 @@ package webhook
import (
"context"
"fmt"
repoInterfaces "github.com/flyteorg/flyteadmin/pkg/repositories/interfaces"
"time"

repoInterfaces "github.com/flyteorg/flyteadmin/pkg/repositories/interfaces"

"github.com/NYTimes/gizmo/pubsub"
gizmoAWS "github.com/NYTimes/gizmo/pubsub/aws"
"github.com/flyteorg/flyteadmin/pkg/async"
Original file line number Diff line number Diff line change
@@ -4,13 +4,14 @@ import (
"context"
"encoding/base64"
"encoding/json"
"time"

"github.com/flyteorg/flyteadmin/pkg/common"
"github.com/flyteorg/flyteadmin/pkg/manager/impl/util"
repoInterfaces "github.com/flyteorg/flyteadmin/pkg/repositories/interfaces"
"github.com/flyteorg/flyteadmin/pkg/repositories/transformers"
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
"github.com/golang/protobuf/proto"
"time"

"github.com/NYTimes/gizmo/pubsub"
"github.com/flyteorg/flyteadmin/pkg/async"
5 changes: 3 additions & 2 deletions flyteadmin/pkg/async/webhook/implementations/slack_webhook.go
Original file line number Diff line number Diff line change
@@ -4,11 +4,12 @@ import (
"bytes"
"context"
"fmt"
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
"github.com/flyteorg/flytepropeller/pkg/controller/nodes/task/secretmanager"
"io/ioutil"
"net/http"

"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
"github.com/flyteorg/flytepropeller/pkg/controller/nodes/task/secretmanager"

"github.com/flyteorg/flytestdlib/logger"

"github.com/flyteorg/flyteadmin/pkg/async/webhook/interfaces"
1 change: 1 addition & 0 deletions flyteadmin/pkg/async/webhook/interfaces/webhook.go
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@ package interfaces

import (
"context"

runtimeInterfaces "github.com/flyteorg/flyteadmin/pkg/runtime/interfaces"
"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
)
3 changes: 3 additions & 0 deletions flyteadmin/pkg/async/webhook/mocks/processor.go
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@ package mocks

import (
"context"

runtimeInterfaces "github.com/flyteorg/flyteadmin/pkg/runtime/interfaces"

"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/admin"
@@ -11,6 +12,8 @@ type RunFunc func() error

type StopFunc func() error

type WebhookPostFunc func(ctx context.Context, payload admin.WebhookPayload) error

type MockSubscriber struct {
runFunc RunFunc
stopFunc StopFunc