Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idl push on artifacts branch push #4442

Closed
wants to merge 4 commits into from

Conversation

squiishyy
Copy link
Contributor

Tracking issue

Docs link

Describe your changes

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

jeevb and others added 4 commits November 13, 2023 13:34
Signed-off-by: davidmirror-ops <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Kevin Su <[email protected]>
* Small corrections to dashboard generation scripts

Signed-off-by: Thomas Newton <[email protected]>

* New generated dashboards

Signed-off-by: Thomas Newton <[email protected]>

* Avoid many-to-many mapping

Signed-off-by: Thomas Newton <[email protected]>

* Multiply by 100 for a percentage

Signed-off-by: Thomas Newton <[email protected]>

* Update user dashboard

Signed-off-by: Thomas Newton <[email protected]>

* Fix `make stats` without hacking grafanalib library

Signed-off-by: Thomas Newton <[email protected]>

* Revert extra filter needed in our setup

Signed-off-by: Thomas Newton <[email protected]>

* Delete unused metrics related yaml

Signed-off-by: Thomas Newton <[email protected]>

* Update flyteuser dashboard

Signed-off-by: Thomas Newton <[email protected]>

* Fix for flyteadmin replicas

---------

Signed-off-by: Thomas Newton <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
@squiishyy squiishyy changed the base branch from master to artifacts November 17, 2023 02:27
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (033276d) 59.81% compared to head (d356e56) 60.58%.
Report is 18 commits behind head on artifacts.

❗ Current head d356e56 differs from pull request most recent head 266788f. Consider uploading reports for the commit 266788f to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           artifacts    #4442      +/-   ##
=============================================
+ Coverage      59.81%   60.58%   +0.76%     
=============================================
  Files            632      380     -252     
  Lines          53628    26125   -27503     
=============================================
- Hits           32076    15827   -16249     
+ Misses         19027     8832   -10195     
+ Partials        2525     1466    -1059     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squiishyy squiishyy closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants