-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the error message for databricks plugins #4477
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4477 +/- ##
==========================================
+ Coverage 58.97% 58.98% +0.01%
==========================================
Files 645 645
Lines 55562 55542 -20
==========================================
- Hits 32767 32764 -3
+ Misses 20200 20187 -13
+ Partials 2595 2591 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just test is in RetryableFailure
.
It will not retry by max attempts[11/10]
I will try to fix it in this PR.
#4983
graph link: https://app.heptabase.com/w/d6ce5a6270c70e56b86e10dd987df499a867def1050c2318fa4daad6b93df450
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Tracking issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1700141111460659
Docs link
Describe your changes
failed
instead ofundefined
if propeller failed to submit a job.Check all the applicable boxes
Setup Process
Screenshots
Note to reviewers
Related PRs