Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message for databricks plugins #4477

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Nov 24, 2023

Tracking issue

https://flyte-org.slack.com/archives/CP2HDHKE1/p1700141111460659

Docs link

Describe your changes

  • Improve the error message for Databricks plugin
  • Transitision node status to failed instead of undefined if propeller failed to submit a job.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

image

Note to reviewers

Related PRs

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: Patch coverage is 61.95652% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 58.98%. Comparing base (4270c53) to head (909dd46).

Files Patch % Lines
...ugins/go/tasks/plugins/webapi/databricks/plugin.go 61.53% 27 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4477      +/-   ##
==========================================
+ Coverage   58.97%   58.98%   +0.01%     
==========================================
  Files         645      645              
  Lines       55562    55542      -20     
==========================================
- Hits        32767    32764       -3     
+ Misses      20200    20187      -13     
+ Partials     2595     2591       -4     
Flag Coverage Δ
unittests 58.98% <61.95%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 28, 2023
Future-Outlier
Future-Outlier previously approved these changes Jan 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2024
Signed-off-by: Kevin Su <[email protected]>
Future-Outlier
Future-Outlier previously approved these changes Mar 4, 2024
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just test is in RetryableFailure.
image
It will not retry by max attempts[11/10]
I will try to fix it in this PR.
#4983

image

graph link: https://app.heptabase.com/w/d6ce5a6270c70e56b86e10dd987df499a867def1050c2318fa4daad6b93df450

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pingsutw pingsutw merged commit 99dad35 into master Mar 5, 2024
49 checks passed
@pingsutw pingsutw deleted the fix-databricks branch March 5, 2024 23:17
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants