Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change artifacts HTTP paths #4554

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

squiishyy
Copy link
Contributor

Why are the changes needed?

Being more declarative about talking to artifacts service in the http paths

@squiishyy squiishyy requested a review from eapolinario December 7, 2023 21:52
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (232a1c7) 60.34% compared to head (fbdbff3) 60.30%.

Additional details and impacted files
@@              Coverage Diff              @@
##           artifacts    #4554      +/-   ##
=============================================
- Coverage      60.34%   60.30%   -0.04%     
=============================================
  Files            453      453              
  Lines          36511    36493      -18     
=============================================
- Hits           22032    22007      -25     
- Misses         12841    12846       +5     
- Partials        1638     1640       +2     
Flag Coverage Δ
unittests 60.30% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squiishyy squiishyy merged commit 3897e86 into artifacts Dec 8, 2023
40 of 47 checks passed
@squiishyy squiishyy deleted the artifacts-change-protos-path branch December 8, 2023 00:26
@wild-endeavor
Copy link
Contributor

wait why was this done to artifacts. the base branch here should be artifacts-shell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants