Return InvalidArgument for workflow compilation failures in CreateWorkflow #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kflow Signed-off-by: Katrina Rogan <[email protected]>
dosubot
bot
added
the
size:XS
Signed-off-by: Katrina Rogan <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4566 +/- ##
==========================================
- Coverage 58.98% 58.92% -0.06%
==========================================
Files 621 620 -1
Lines 52483 52432 -51
==========================================
- Hits 30957 30896 -61
- Misses 19059 19071 +12
+ Partials 2467 2465 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Dec 9, 2023
hamersaw
approved these changes
Dec 11, 2023
pmahindrakar-oss
approved these changes
Dec 11, 2023
pvditt
pushed a commit
that referenced
this pull request
Dec 13, 2023
…kflow (#4566) * Return InvalidArgument for workflow compilation failures in CreateWorkflow Signed-off-by: Katrina Rogan <[email protected]> * lint Signed-off-by: Katrina Rogan <[email protected]> --------- Signed-off-by: Katrina Rogan <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#4565
Why are the changes needed?
Invalid workflow specs passed to CreateWorkflow calls currently return Internal grpc status response codes and are erroneously treated as server rather than user errors.
As far as I could tell, the compiler propagates compiler errors that only surface due to invalid workflow definitions
What changes were proposed in this pull request?
Updates workflow compilation handling to return a more accurate response code.
How was this patch tested?
Added unit tests.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link