monodocs - gracefully handle case when external repo doesn't contain tags: use current commit #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <[email protected]>
dosubot
bot
added
the
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4598 +/- ##
=======================================
Coverage 59.00% 59.00%
=======================================
Files 621 621
Lines 52498 52498
=======================================
+ Hits 30974 30975 +1
+ Misses 19057 19056 -1
Partials 2467 2467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy
changed the title
Signed-off-by: Niels Bantilan <[email protected]>
thomasjpfan
reviewed
Dec 14, 2023
Signed-off-by: Niels Bantilan <[email protected]>
thomasjpfan
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR elegantly handles the case when an external repo (flytekit, flytesnacks, flytectl) does not have tags due to a cloning a copy of the repo with a depth of 0. This fixes a docs build issue caused by the fact that github actions
checkoutwill fetch the latest commit (sincefetch-depth: 0by default), see: https://github.com/flyteorg/flytesnacks/actions/runs/7204216790/job/19625299915?pr=1315