Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] fix CI sandbox test #4608

Conversation

Future-Outlier
Copy link
Member

Tracking issue

https://github.com/flyteorg/flyte/issues/

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future Outlier <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Dec 17, 2023
@Future-Outlier Future-Outlier marked this pull request as draft December 17, 2023 13:07
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (398e5cb) 59.03% compared to head (7940ac9) 58.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4608      +/-   ##
==========================================
- Coverage   59.03%   58.45%   -0.59%     
==========================================
  Files         622      472     -150     
  Lines       52682    40435   -12247     
==========================================
- Hits        31102    23637    -7465     
+ Misses      19098    14892    -4206     
+ Partials     2482     1906     -576     
Flag Coverage Δ
unittests 58.45% <ø> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant