Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly computing ArrayNode maximum attempts and system failures #4627

Merged
merged 7 commits into from
Dec 20, 2023

Merge branch 'master' into bug/arraynode-attempts-max-values

cdf07a1
Select commit
Loading
Failed to load commit list.
Merged

Correctly computing ArrayNode maximum attempts and system failures #4627

Merge branch 'master' into bug/arraynode-attempts-max-values
cdf07a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2023 in 0s

59.03% (+0.01%) compared to 3501675

View this Pull Request on Codecov

59.03% (+0.01%) compared to 3501675

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3501675) 59.02% compared to head (cdf07a1) 59.03%.

Files Patch % Lines
...ytepropeller/pkg/controller/nodes/array/handler.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4627      +/-   ##
==========================================
+ Coverage   59.02%   59.03%   +0.01%     
==========================================
  Files         622      622              
  Lines       52775    52780       +5     
==========================================
+ Hits        31148    31157       +9     
+ Misses      19140    19138       -2     
+ Partials     2487     2485       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.