Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel exporter for http collector endpoint #4650

Closed
wants to merge 7 commits into from

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Dec 29, 2023

Tracking issue

NA

Why are the changes needed?

Currently using the otel integration requires deploying an otel collector compatible endpoint in the benchmarking environment. Managing this deployment (ie. deployment, endpoint access, etc) can add unnecessary difficulty to ad-hoc benchmarking.

What changes were proposed in this pull request?

For quick benchmarking this PR enables the file exporter to write json marhsalled protobufs to satisfy the otel http collector endpoint. The flow here is as follows:

  1. enable otel_collector file exporter in propeller
  2. execute workflow(s)
  3. download exported file
  4. import into jaeger (or other otel collector compatible framework)
  5. profit

How was this patch tested?

local, cloud, etc

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 379 lines in your changes are missing coverage. Please review.

Comparison is base (75c2b08) 58.15% compared to head (994a946) 57.74%.
Report is 1 commits behind head on master.

Files Patch % Lines
flytestdlib/otelutils/span.go 0.00% 267 Missing ⚠️
flytestdlib/otelutils/file_exporter.go 6.60% 99 Missing ⚠️
flytestdlib/otelutils/factory.go 40.90% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4650      +/-   ##
==========================================
- Coverage   58.15%   57.74%   -0.41%     
==========================================
  Files         626      628       +2     
  Lines       53786    54169     +383     
==========================================
+ Hits        31277    31281       +4     
- Misses      20001    20380     +379     
  Partials     2508     2508              
Flag Coverage Δ
unittests 57.74% <4.29%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw marked this pull request as ready for review January 11, 2024 18:46
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Jan 11, 2024
@hamersaw hamersaw closed this Feb 9, 2024
@hamersaw hamersaw deleted the feature/otel-json-file branch February 9, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant