Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org to identifier protos #4663

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Add org to identifier protos #4663

merged 8 commits into from
Jan 16, 2024

Conversation

katrogan
Copy link
Contributor

@katrogan katrogan commented Jan 3, 2024

Tracking issue

See RFC: #4588

Why are the changes needed?

This change adds an optional 'org' to Flyte core identifiers

What changes were proposed in this pull request?

How was this patch tested?

Tested on a deployment of flyte with the admin code changes pulled in. Did not observe regressions with running workflows

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Katrina Rogan <[email protected]>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75c2b08) 58.15% compared to head (fc16f16) 58.15%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4663   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files         626      626           
  Lines       53786    53786           
=======================================
  Hits        31277    31277           
  Misses      20001    20001           
  Partials     2508     2508           
Flag Coverage Δ
unittests 58.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
pingsutw
pingsutw previously approved these changes Jan 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 3, 2024
Copy link
Contributor

@hamersaw hamersaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does updating the DatasetID proto in datacatalog automatically update the cache key? If so this basically invalidates all existing caches unless we write a fallback right?

@@ -129,6 +135,9 @@ message NamedEntityListRequest {
// +optional
string filters = 7;

// Optional, org key applied to the resource.
string org = 8;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - ending space is unnecessary i think

flyteidl/protos/flyteidl/datacatalog/datacatalog.proto Outdated Show resolved Hide resolved
flyteidl/protos/flyteidl/service/admin.proto Outdated Show resolved Hide resolved
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan
Copy link
Contributor Author

katrogan commented Jan 4, 2024

Does updating the DatasetID proto in datacatalog automatically update the cache key? If so this basically invalidates all existing caches unless we write a fallback right?

@hamersaw we don't actually change how we write the DB keys in datacatalog based on these IDL changes

in Create requests, we change the metadata accordingly but not the key

and in Get requests the datasetKey is still explicitly constructed using the same identifier fields so this should not nuke datacatalog I believe

Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan requested a review from hamersaw January 4, 2024 00:38
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan requested a review from hamersaw January 4, 2024 20:01
hamersaw
hamersaw previously approved these changes Jan 4, 2024
pingsutw
pingsutw previously approved these changes Jan 4, 2024
@katrogan
Copy link
Contributor Author

katrogan commented Jan 4, 2024

PTAL @EngHabu

@katrogan katrogan requested a review from EngHabu January 4, 2024 21:34
EngHabu
EngHabu previously approved these changes Jan 5, 2024
@katrogan katrogan requested a review from EngHabu January 11, 2024 22:23
@katrogan katrogan dismissed stale reviews from EngHabu, pingsutw, and hamersaw via 560ffac January 12, 2024 00:48
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 12, 2024
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 12, 2024
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
@katrogan katrogan merged commit 03e94e9 into master Jan 16, 2024
44 of 45 checks passed
@katrogan katrogan deleted the org-identifier-id branch January 16, 2024 17:45
pmahindrakar-oss pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Implemented
Development

Successfully merging this pull request may close these issues.

4 participants