-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Spark docs v2 #4670
Update Spark docs v2 #4670
Conversation
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: David Espejo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4670 +/- ##
==========================================
+ Coverage 58.11% 58.15% +0.03%
==========================================
Files 626 626
Lines 53815 53786 -29
==========================================
+ Hits 31275 31277 +2
+ Misses 20039 20001 -38
- Partials 2501 2508 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
|
||
Enable the Spark plugin on the demo cluster by adding the following block to ~/.flyte/sandbox/config.yaml: | ||
|
||
.. code-block:: yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be indented. i think you haven't copied the whole config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked and there are the same three sections in the live docs: tasks
, plugins
and cluster_resources
. Also checked indentation and it should be fine. It uses the same spacing as in a working deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i haven't tested the spark one 'cause it didn't work for me earlier. but i believe this is how it needs to be done. but we need to test the config.
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment (apologies, should have checked it before); if you've already added, please merge the PR.
Tracking issue
Closes #4545
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link