Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dockerfiles from subfolder #4715

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Remove dockerfiles from subfolder #4715

merged 1 commit into from
Jan 11, 2024

Conversation

pingsutw
Copy link
Member

Why are the changes needed?

All the docker files in the subfolder are unused and outdated.

What changes were proposed in this pull request?

Remove them

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac42562) 58.13% compared to head (0969ded) 58.15%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4715      +/-   ##
==========================================
+ Coverage   58.13%   58.15%   +0.01%     
==========================================
  Files         626      626              
  Lines       53786    53786              
==========================================
+ Hits        31271    31277       +6     
+ Misses      20007    20001       -6     
  Partials     2508     2508              
Flag Coverage Δ
unittests 58.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw self-assigned this Jan 10, 2024
@pingsutw
Copy link
Member Author

cc @pmahindrakar-oss

@pmahindrakar-oss
Copy link
Contributor

Can we also have make docker_build work for each component so that it picks the right Dockerfile based on the component
Eg : If you are inside flytepropellerdirectory and you do make docker_build then it picks Dockerfile.propeller and builds that.

Cloud repo has this convention. Happy to have this as separate ticket too. Thanks for taking care of this

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2024
@pingsutw pingsutw merged commit 75c2b08 into master Jan 11, 2024
45 checks passed
@pingsutw pingsutw deleted the remove-dockerfile branch January 11, 2024 00:18
@pingsutw
Copy link
Member Author

That's a good idea. I'll add that in a separate PR.

katrogan pushed a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants