Removed orphaned kube exectors from FlytePropeller #4722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
size:L
hamersaw
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4722 +/- ##
==========================================
- Coverage 58.15% 58.14% -0.01%
==========================================
Files 626 625 -1
Lines 53786 53745 -41
==========================================
- Hits 31277 31251 -26
+ Misses 20001 19989 -12
+ Partials 2508 2505 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pvditt
approved these changes
Jan 16, 2024
|
closing in favor of #4733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Update k8s Dependencies by EngHabu · Pull Request #4199 · flyteorg/flyte updated the kube executors to fallthrough to the regular k8s implementations. The means that everything in this file is essentially fluff. The WriteThroughClient is not long used and the FallbackClientBuilder just builds a k8s client. This all can be removed.
What changes were proposed in this pull request?
Removes orphaned code.
How was this patch tested?
local, cloud, etc
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA