Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow controlling in which task phases log links are shown #4726

Merged
merged 35 commits into from
Jun 17, 2024

Merge branch 'master' into fg91/feat/log-links-show-while-pending

3bfba55
Select commit
Loading
Failed to load commit list.
Merged

Feat: Allow controlling in which task phases log links are shown #4726

Merge branch 'master' into fg91/feat/log-links-show-while-pending
3bfba55
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 17, 2024 in 0s

61.00% (+0.00%) compared to de415af

View this Pull Request on Codecov

61.00% (+0.00%) compared to de415af

Details

Codecov Report

Attention: Patch coverage is 82.35294% with 24 lines in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (de415af) to head (3bfba55).

Files Patch % Lines
flyteplugins/go/tasks/plugins/k8s/spark/spark.go 80.95% 4 Missing and 4 partials ⚠️
flyteplugins/go/tasks/plugins/k8s/dask/dask.go 83.33% 2 Missing and 2 partials ⚠️
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 72.72% 2 Missing and 1 partial ⚠️
...lugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go 60.00% 1 Missing and 1 partial ⚠️
...o/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go 60.00% 1 Missing and 1 partial ⚠️
...s/plugins/k8s/kfoperators/tensorflow/tensorflow.go 60.00% 1 Missing and 1 partial ⚠️
flyteplugins/go/tasks/logs/logging_utils.go 75.00% 0 Missing and 1 partial ⚠️
...lyteplugins/go/tasks/pluginmachinery/core/phase.go 0.00% 1 Missing ⚠️
...ns/go/tasks/pluginmachinery/flytek8s/pod_helper.go 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4726   +/-   ##
=======================================
  Coverage   61.00%   61.00%           
=======================================
  Files         793      793           
  Lines       51378    51419   +41     
=======================================
+ Hits        31342    31370   +28     
- Misses      17149    17157    +8     
- Partials     2887     2892    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov