Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/Clarify propeller scaling #4741

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Docs/Clarify propeller scaling #4741

merged 1 commit into from
Jan 18, 2024

Conversation

wild-endeavor
Copy link
Contributor

The enumer generated code needs the type to be Hash not hash. Also clarify that it's not autoscaling in the traditional sense.

Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 18, 2024
Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ace0967) 58.18% compared to head (40e77ff) 58.17%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4741      +/-   ##
==========================================
- Coverage   58.18%   58.17%   -0.01%     
==========================================
  Files         626      626              
  Lines       53833    53833              
==========================================
- Hits        31321    31316       -5     
- Misses      20004    20009       +5     
  Partials     2508     2508              
Flag Coverage Δ
unittests 58.17% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit 3eedbda into master Jan 18, 2024
44 of 45 checks passed
@wild-endeavor wild-endeavor deleted the docs/hash branch January 18, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants