Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger with formatter #4747

Merged
merged 2 commits into from
Jan 20, 2024

Use logger with formatter for fatal

3526294
Select commit
Loading
Failed to load commit list.
Merged

Use logger with formatter #4747

Use logger with formatter for fatal
3526294
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 19, 2024 in 0s

23.52% of diff hit (target 58.18%)

View this Pull Request on Codecov

23.52% of diff hit (target 58.18%)

Annotations

Check warning on line 84 in flyteadmin/dataproxy/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/dataproxy/service.go#L84

Added line #L84 was not covered by tests

Check warning on line 65 in flyteadmin/scheduler/executor/executor_impl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/scheduler/executor/executor_impl.go#L65

Added line #L65 was not covered by tests

Check warning on line 110 in flyteadmin/scheduler/executor/executor_impl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/scheduler/executor/executor_impl.go#L110

Added line #L110 was not covered by tests

Check warning on line 121 in flyteadmin/scheduler/executor/executor_impl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/scheduler/executor/executor_impl.go#L121

Added line #L121 was not covered by tests

Check warning on line 46 in flyteplugins/go/tasks/pluginmachinery/ioutils/paths.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/ioutils/paths.go#L46

Added line #L46 was not covered by tests

Check warning on line 275 in flyteplugins/go/tasks/plugins/array/awsbatch/jobs_store.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/array/awsbatch/jobs_store.go#L275

Added line #L275 was not covered by tests

Check warning on line 131 in flyteplugins/go/tasks/plugins/webapi/athena/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/athena/plugin.go#L131

Added line #L131 was not covered by tests

Check warning on line 259 in flyteplugins/go/tasks/plugins/webapi/bigquery/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/bigquery/plugin.go#L259

Added line #L259 was not covered by tests

Check warning on line 206 in flyteplugins/go/tasks/plugins/webapi/databricks/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/databricks/plugin.go#L206

Added line #L206 was not covered by tests

Check warning on line 182 in flyteplugins/go/tasks/plugins/webapi/snowflake/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/snowflake/plugin.go#L182

Added line #L182 was not covered by tests

Check warning on line 586 in flytepropeller/pkg/controller/nodes/executor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/executor.go#L586

Added line #L586 was not covered by tests

Check warning on line 151 in flytepropeller/pkg/controller/nodes/subworkflow/launchplan/admin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/subworkflow/launchplan/admin.go#L151

Added line #L151 was not covered by tests

Check warning on line 49 in flytestdlib/storage/protobuf_store.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytestdlib/storage/protobuf_store.go#L49

Added line #L49 was not covered by tests