Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Reapply Databricks agent docs changes from #4008 #4751

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Jan 19, 2024

Why are the changes needed?

This PR reapplies docs changes made to the old docs after the monodocs branch was created, specifically, the changes in #4008.

What changes were proposed in this pull request?

See #4008 -- this PR adds the Databricks agent doc, plus other changes from that PR, slightly modified to fit the new docs structure.

How was this patch tested?

TBD

Related PRs

#4008

Docs link

https://flyte--4751.org.readthedocs.build/en/4751/flytesnacks/examples/databricks_plugin/index.html

@neverett neverett requested review from ppiegaze and pingsutw January 19, 2024 21:07
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d3f961) 58.18% compared to head (8ffe846) 58.18%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4751   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files         626      626           
  Lines       53833    53833           
=======================================
+ Hits        31321    31322    +1     
+ Misses      20004    20003    -1     
  Partials     2508     2508           
Flag Coverage Δ
unittests 58.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, are there any docs else affected by Mono Docs changed?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2024
@Future-Outlier Future-Outlier merged commit 5300e1b into master Jan 21, 2024
45 checks passed
@Future-Outlier Future-Outlier deleted the docs/databricks-agent-doc branch January 21, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants