Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[housekeeping] Remove pull_request_template from each subdirectory #4753

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

pingsutw
Copy link
Member

What changes were proposed in this pull request?

delete pull_request_template file from each subdirectory

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2866d5a) 58.18% compared to head (6077d5e) 58.17%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4753      +/-   ##
==========================================
- Coverage   58.18%   58.17%   -0.02%     
==========================================
  Files         626      626              
  Lines       53833    53833              
==========================================
- Hits        31322    31316       -6     
- Misses      20003    20009       +6     
  Partials     2508     2508              
Flag Coverage Δ
unittests 58.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we remove other files and directories related to pull_request_template?
image

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2024
@pingsutw
Copy link
Member Author

we will remove boilerplate later

@pingsutw pingsutw merged commit be03528 into master Jan 21, 2024
44 of 45 checks passed
@pingsutw pingsutw deleted the remove-pr-template branch January 21, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants