Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Remove broken link from Understand How Flyte Handles Data page (for new monodocs site) (second attempt) #4757

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Jan 22, 2024

Tracking issue

Re-applies the change in #4518. I opened this new PR for this change since I was unable to fast forward or rebase the branch in #4547

Why are the changes needed?

The change in #4518 was made after the monodocs branch was created, so we need to bring that change over now that the monodocs PR has been merged.

What changes were proposed in this pull request?

Removes broken link from "Bringing in Your Own Datastores for Raw Data" section of "Understand How Flyte Handles Data" docs page.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#4518
#4547

Docs link

https://flyte--4757.org.readthedocs.build/en/4757/concepts/data_management.html#bringing-in-your-own-datastores-for-raw-data

Signed-off-by: nikki everett <[email protected]>
@neverett neverett requested review from ppiegaze and pingsutw January 22, 2024 17:25
@neverett neverett self-assigned this Jan 22, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5300e1b) 58.17% compared to head (1a01f33) 58.17%.
Report is 8 commits behind head on master.

❗ Current head 1a01f33 differs from pull request most recent head e854ed5. Consider uploading reports for the commit e854ed5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4757   +/-   ##
=======================================
  Coverage   58.17%   58.17%           
=======================================
  Files         626      626           
  Lines       53833    53833           
=======================================
+ Hits        31315    31316    +1     
+ Misses      20010    20009    -1     
  Partials     2508     2508           
Flag Coverage Δ
unittests 58.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nikki everett <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 24, 2024
@neverett neverett merged commit a23b266 into master Jan 26, 2024
43 checks passed
@neverett neverett deleted the nikki-remove-link-again branch January 26, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants