Bring Scheme back for backwards compatibility #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
dosubot
bot
added
size:L
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4789 +/- ##
==========================================
- Coverage 58.64% 58.51% -0.13%
==========================================
Files 590 625 +35
Lines 51473 53633 +2160
==========================================
+ Hits 30187 31386 +1199
- Misses 18861 19730 +869
- Partials 2425 2517 +92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EngHabu
previously approved these changes
Jan 30, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
EngHabu
approved these changes
Jan 30, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
May 1, 2024
* Dynamic log links (#4774) * Bring Scheme back for backwards compatibility (#4789) * Bring Scheme back for backwards compatibility Signed-off-by: Eduardo Apolinario <[email protected]> * Rename deprecated field to `DeprecatedScheme` Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
We removed Scheme in #4774, but in order to help backwards compatibility, we need to keep it. This PR brings it back.
What changes were proposed in this pull request?
Revert a portion of #4774.
I also fixed a small issue in the parsing of ray config.
How was this patch tested?
Sandbox.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link