propeller gc ttl comparison should allow 23 #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4791 +/- ##
==========================================
- Coverage 58.64% 58.57% -0.08%
==========================================
Files 590 624 +34
Lines 51473 53627 +2154
==========================================
+ Hits 30187 31410 +1223
- Misses 18861 19699 +838
- Partials 2425 2518 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
The GC TTL configuration defaults to 23 in propeller configuration, but the comparison logs a warning if the value is not less than 23 and then proceeds to reset to 23. The correct approach is to make the comparison allow 23.
What changes were proposed in this pull request?
^^^
How was this patch tested?
Locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA