-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate version with setuptools_scm and migrate to pyproject.toml #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jan 31, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
the
housekeeping
Issues that help maintain flyte and keep it tech-debt free
label
Jan 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4799 +/- ##
=======================================
Coverage 58.98% 58.99%
=======================================
Files 644 644
Lines 55145 55145
=======================================
+ Hits 32528 32533 +5
+ Misses 20043 20040 -3
+ Partials 2574 2572 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
wild-endeavor
approved these changes
Feb 5, 2024
eapolinario
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Remove the need for custom code to wrangle the version during release.
What changes were proposed in this pull request?
Migrate to pyproject.toml and use setuptools_scm to generate the version based on tags. If the build is run on a commit that is also tagged, the version is the tag. For a development build, it will bump the version by +0.0.1.dev*, which has a "dev" tag at the end.
(base) ➜ flyteidl git:(project.toml) ✗ pip list | grep flyteidl flyteidl 1.10.7b3.dev34+g9d4761370 /Users/kevin/git/flyte/flyteidl