Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate version with setuptools_scm and migrate to pyproject.toml #4799

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jan 31, 2024

Why are the changes needed?
Remove the need for custom code to wrangle the version during release.

What changes were proposed in this pull request?
Migrate to pyproject.toml and use setuptools_scm to generate the version based on tags. If the build is run on a commit that is also tagged, the version is the tag. For a development build, it will bump the version by +0.0.1.dev*, which has a "dev" tag at the end.

(base) ➜  flyteidl git:(project.toml) ✗ pip list | grep flyteidl
flyteidl                      1.10.7b3.dev34+g9d4761370         /Users/kevin/git/flyte/flyteidl

@pingsutw pingsutw self-assigned this Jan 31, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 31, 2024
@pingsutw pingsutw marked this pull request as draft January 31, 2024 13:23
@dosubot dosubot bot added the enhancement New feature or request label Jan 31, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw marked this pull request as ready for review January 31, 2024 23:47
@dosubot dosubot bot added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d24d23) 58.98% compared to head (9fc952a) 58.99%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4799   +/-   ##
=======================================
  Coverage   58.98%   58.99%           
=======================================
  Files         644      644           
  Lines       55145    55145           
=======================================
+ Hits        32528    32533    +5     
+ Misses      20043    20040    -3     
+ Partials     2574     2572    -2     
Flag Coverage Δ
unittests 58.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2024
@eapolinario eapolinario merged commit 6a2ce3f into master Feb 6, 2024
48 of 49 checks passed
@eapolinario eapolinario deleted the project.toml branch February 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants