-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change propeller compiler test #4823
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
housekeeping
Issues that help maintain flyte and keep it tech-debt free
labels
Feb 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## buf-experiment #4823 +/- ##
=================================================
Coverage ? 59.76%
=================================================
Files ? 462
Lines ? 37273
Branches ? 0
=================================================
Hits ? 22278
Misses ? 13323
Partials ? 1672
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eapolinario
approved these changes
Feb 2, 2024
eapolinario
added a commit
that referenced
this pull request
Feb 6, 2024
* use buf Signed-off-by: Yee Hing Tong <[email protected]> * Remove java and cpp. Signed-off-by: Eduardo Apolinario <[email protected]> * Add es and connect-es to buf.gen.yaml and generate files Signed-off-by: Eduardo Apolinario <[email protected]> * Generated go code. Signed-off-by: Eduardo Apolinario <[email protected]> * Add generated python code. Signed-off-by: Eduardo Apolinario <[email protected]> * Uncomment openapiv2 definitions. Signed-off-by: Eduardo Apolinario <[email protected]> * Remove go and python swagger-generated code Signed-off-by: Eduardo Apolinario <[email protected]> * Remove swagger-related code from makefile and scripts Signed-off-by: Eduardo Apolinario <[email protected]> * Stop generating code for cpp and java Signed-off-by: Eduardo Apolinario <[email protected]> * Stop go code generation in script Signed-off-by: Eduardo Apolinario <[email protected]> * Remove docs generated code Signed-off-by: Eduardo Apolinario <[email protected]> * Do not generate openapiv2 asset Signed-off-by: Eduardo Apolinario <[email protected]> * Lint Signed-off-by: Eduardo Apolinario <[email protected]> * Update go.mod Signed-off-by: Eduardo Apolinario <[email protected]> * Drop os from flyteadmin service Signed-off-by: Eduardo Apolinario <[email protected]> * make go-tidy Signed-off-by: Eduardo Apolinario <[email protected]> * Fix test Signed-off-by: Eduardo Apolinario <[email protected]> * Fix datacatalog Signed-off-by: Eduardo Apolinario <[email protected]> * Lint flyteadmin, flyteplugins, and flytepropeller. Signed-off-by: Eduardo Apolinario <[email protected]> * fix up datacatalog tests Signed-off-by: Yee Hing Tong <[email protected]> * one more test fix Signed-off-by: Yee Hing Tong <[email protected]> * fix tests Signed-off-by: Yee Hing Tong <[email protected]> * plugin test Signed-off-by: Yee Hing Tong <[email protected]> * more test failure, the spacing seems to be different on gh Signed-off-by: Yee Hing Tong <[email protected]> * starting admin Signed-off-by: Yee Hing Tong <[email protected]> * Fix flyteadmin tests Signed-off-by: Eduardo Apolinario <[email protected]> * change propeller compiler test (#4823) Signed-off-by: Yee Hing Tong <[email protected]> * Add regex to fix tests Signed-off-by: Eduardo Apolinario <[email protected]> * Pin versions of typescript buf plugins Signed-off-by: Eduardo Apolinario <[email protected]> * Add utility AssertEqualWithSanitizedRegex and fix flyteadmin tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix integration test Signed-off-by: Eduardo Apolinario <[email protected]> * Lint Signed-off-by: Eduardo Apolinario <[email protected]> * More linting Signed-off-by: Eduardo Apolinario <[email protected]> * Lint again Signed-off-by: Eduardo Apolinario <[email protected]> * Add protoc-gen-openapiv2 as a dependence in flyteidl Signed-off-by: Eduardo Apolinario <[email protected]> * Serve swagger file using golang's embed. Signed-off-by: Eduardo Apolinario <[email protected]> * Fix datacatalog tests Signed-off-by: Eduardo Apolinario <[email protected]> * Fix a few more flyteadmin tests Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Yee Hing Tong <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
housekeeping
Issues that help maintain flyte and keep it tech-debt free
lgtm
This PR has been approved by a maintainer
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update how the propeller compile test works.
branch
directory test since walking through it, it didn't actually do anything. Leaving it there as a comment for now.