Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Airflow migration guide #4871

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Add Airflow migration guide #4871

merged 6 commits into from
Mar 6, 2024

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Feb 8, 2024

What changes were proposed in this pull request?

Adds @pingsutw Airflow migration guide from flyteorg/flytesnacks#1481 to Flyte, since the contents of the flytesnacks/docs directory have been moved to this repo.

Note: The link to the Airflow agent deployment guide is broken, since that guide is in a branch. This PR should be merged after #4822.

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytesnacks#1481

Docs link

https://flyte--4871.org.readthedocs.build/en/4871/migrating_to_flyte/index.html

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.98%. Comparing base (33265b9) to head (66af8ce).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4871      +/-   ##
==========================================
+ Coverage   58.97%   58.98%   +0.01%     
==========================================
  Files         645      645              
  Lines       55561    55542      -19     
==========================================
- Hits        32766    32764       -2     
+ Misses      20200    20187      -13     
+ Partials     2595     2591       -4     
Flag Coverage Δ
unittests 58.98% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nikki everett added 2 commits February 20, 2024 20:26
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
@neverett neverett marked this pull request as ready for review February 21, 2024 02:49
@neverett neverett requested a review from ppiegaze as a code owner February 21, 2024 02:49
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Feb 21, 2024
@neverett neverett requested review from ppiegaze and removed request for ppiegaze February 21, 2024 02:49
@neverett neverett changed the title Add Airflow migration guide [Wait to merge] Add Airflow migration guide Feb 21, 2024
ppiegaze
ppiegaze previously approved these changes Feb 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 22, 2024
Signed-off-by: nikki everett <[email protected]>
@neverett neverett requested a review from ppiegaze February 29, 2024 19:26
@neverett neverett changed the title [Wait to merge] Add Airflow migration guide Add Airflow migration guide Feb 29, 2024
@neverett neverett self-assigned this Feb 29, 2024
@neverett neverett merged commit bce9b6f into master Mar 6, 2024
49 checks passed
@neverett neverett deleted the docs/migration-guides branch March 6, 2024 16:59
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
* move @pingsutw airflow migration doc from flytesnacks branch to flyte

Signed-off-by: nikki everett <[email protected]>

* copy edits

Signed-off-by: nikki everett <[email protected]>

* more copy edits

Signed-off-by: nikki everett <[email protected]>

* move airflow migration guide to development lifecycle section

Signed-off-by: nikki everett <[email protected]>

* copy changes from  docs/migration-guides-ping

Signed-off-by: nikki everett <[email protected]>

---------

Signed-off-by: nikki everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants