Update imageSpec doc #4875
Update imageSpec doc #4875
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4875 +/- ##
==========================================
+ Coverage 58.97% 58.98% +0.01%
==========================================
Files 645 645
Lines 55162 55162
==========================================
+ Hits 32533 32539 +6
+ Misses 20054 20048 -6
Partials 2575 2575
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| # python_version="3.11" | ||
| # # the python version; optional if not different from the base image | ||
| # ) | ||
| basic_image = ImageSpec( |
There was a problem hiding this comment.
This is slightly different from the ImageSpec here: https://github.com/flyteorg/flytekit-python-template/blob/main/basic-template-imagespec/%7B%7Bcookiecutter.project_name%7D%7D/workflows/example.py#L22
Can you update the ImageSpec here to match the template, or if the template should be updated, can you change the template to match what you have here? Thanks!
There was a problem hiding this comment.
updated it here. flyteorg/flytekit-python-template#47
Signed-off-by: Kevin Su <[email protected]>
Update imageSpec doc in
docs/getting_started_with_workflow_development/flyte_project_components.md