-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip - Move flytekit to monorepo #4923
Open
eapolinario
wants to merge
9
commits into
master
Choose a base branch
from
move-flytekit-to-monorepo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
labels
Feb 21, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4923 +/- ##
==========================================
+ Coverage 58.91% 58.96% +0.04%
==========================================
Files 645 645
Lines 55412 55506 +94
==========================================
+ Hits 32648 32731 +83
+ Misses 20181 20177 -4
- Partials 2583 2598 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
housekeeping
Issues that help maintain flyte and keep it tech-debt free
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Prior to this PR, changes in flytekit that require an updated flyteidl need to happen in 2 steps: (1) pin flyteidl in flytekit to a SHA, and once flyteidl is released (2) pin flyteidl version in flytekit to the released version.
What changes were proposed in this pull request?
Move flytekit to the monorepo.
As mentioned in the title, this is wip as there are a bunch of open questions, including:
flyteidl/gen/pb_python
is symlinked).i. I couldn't figure out how to specify a path to a relative dependency in pip. According to https://stackoverflow.com/questions/75159453/specifying-local-relative-dependency-in-pyproject-toml, pip doesn't have support for this. Other package managers like poetry, pdm, and hatch do.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link