Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteadmin] Show diff structure when re-registration two different task with same ids #4924

Merged
merged 13 commits into from
Mar 27, 2024

test: add no diff case

04c34ba
Select commit
Loading
Failed to load commit list.
Merged

[flyteadmin] Show diff structure when re-registration two different task with same ids #4924

test: add no diff case
04c34ba
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2024 in 0s

59.03% (+0.02%) compared to ec0bc4c

View this Pull Request on Codecov

59.03% (+0.02%) compared to ec0bc4c

Details

Codecov Report

Attention: Patch coverage is 69.56522% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 59.03%. Comparing base (ec0bc4c) to head (04c34ba).

Files Patch % Lines
flyteadmin/pkg/manager/impl/task_manager.go 11.11% 8 Missing ⚠️
flyteadmin/pkg/manager/impl/launch_plan_manager.go 0.00% 7 Missing ⚠️
flyteadmin/pkg/manager/impl/workflow_manager.go 33.33% 3 Missing and 1 partial ⚠️
flyteadmin/pkg/errors/errors.go 95.74% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4924      +/-   ##
==========================================
+ Coverage   59.00%   59.03%   +0.02%     
==========================================
  Files         645      645              
  Lines       55672    55726      +54     
==========================================
+ Hits        32850    32896      +46     
- Misses      20226    20233       +7     
- Partials     2596     2597       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov