[draft] disable etag verify for S3 buckets #4931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddl-rliu <[email protected]>
This reverts commit 1110d29. Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
ddl-rliu
commented
Feb 22, 2024
| logger.Infof(ctx, "file already exists at location [%v], specify a matching hash if you wish to rewrite", knownLocation) | ||
| log.Printf("Skipping error :^) Continuing...") | ||
| logger.Infof(ctx, "Skipping error :^) Continuing...") | ||
| // return nil, errors.NewFlyteAdminErrorf(codes.AlreadyExists, "file already exists at location [%v], specify a matching hash if you wish to rewrite", knownLocation) |
There was a problem hiding this comment.
This is the only relevant change in this PR - poc disable this check and verified that file upload to kms bucket now works.
TODO: gate this behind some check.
- [Most likely] Option 1. Selectively disable the check for S3 buckets, since it seems S3 already implements this logic to "deny request if md5 doesn't match"
- [???] Option 2. Selectively disable the check when the bucket is KMS encrypted (?)
There was a problem hiding this comment.
Verified file upload to kms now works
There was a problem hiding this comment.
Caveat: #2328 flyteorg/flyteadmin#587
|
See #4971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
Needed to allow KMS buckets to work with S3. See https://docs.gitlab.com/ee/administration/object_storage.html#etag-mismatch for a summary of the issue, and why the current md5=etag check causes uploads to KMS-encrypted buckets to fail.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link