Generating sandbox-bundled manifests via root Makefile #4940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lo <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4940 +/- ##
==========================================
- Coverage 58.96% 58.92% -0.05%
==========================================
Files 645 645
Lines 55506 55414 -92
==========================================
- Hits 32727 32650 -77
- Misses 20179 20181 +2
+ Partials 2600 2583 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
previously approved these changes
Feb 25, 2024
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Feb 27, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Ryan Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4798
Why are the changes needed?
If charts
flyte-sandboxorflyte-agentare modified, users could easily forget to update manifests for sandbox-bundledWhat changes were proposed in this pull request?
Modify root Makefile to generate manifests for sandbox-bundled while executing
make helmHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link