Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also run dep update #4977

Merged
merged 1 commit into from
Feb 29, 2024
Merged

also run dep update #4977

merged 1 commit into from
Feb 29, 2024

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Feb 29, 2024

The generate flyte manifest job was failing due to deps not being updated. This updates them.

Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Feb 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.97%. Comparing base (e1d5a7a) to head (f7e528d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4977   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         645      645           
  Lines       55561    55561           
=======================================
  Hits        32766    32766           
  Misses      20200    20200           
  Partials     2595     2595           
Flag Coverage Δ
unittests 58.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit 1caa754 into master Feb 29, 2024
52 checks passed
@wild-endeavor wild-endeavor deleted the add-helm-dep-update branch February 29, 2024 03:48
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants