Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking for active node and task execution counts in propeller #4986

Merged
merged 5 commits into from
Apr 4, 2024

Merge remote-tracking branch 'upstream/master' into origin/activenodes

38efa8d
Select commit
Loading
Failed to load commit list.
Merged

Add tracking for active node and task execution counts in propeller #4986

Merge remote-tracking branch 'upstream/master' into origin/activenodes
38efa8d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 4, 2024 in 1s

59.06% (-0.04%) compared to 37255a1

View this Pull Request on Codecov

59.06% (-0.04%) compared to 37255a1

Details

Codecov Report

Attention: Patch coverage is 44.80519% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 59.06%. Comparing base (37255a1) to head (38efa8d).
Report is 1 commits behind head on master.

Files Patch % Lines
...er/pkg/controller/workflowstore/execution_stats.go 32.60% 60 Missing and 2 partials ⚠️
...ller/pkg/controller/executors/execution_context.go 37.50% 10 Missing ⚠️
flytepropeller/pkg/controller/controller.go 0.00% 8 Missing ⚠️
flytepropeller/pkg/controller/workflow/executor.go 83.33% 3 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4986      +/-   ##
==========================================
- Coverage   59.10%   59.06%   -0.04%     
==========================================
  Files         645      646       +1     
  Lines       55581    55714     +133     
==========================================
+ Hits        32851    32910      +59     
- Misses      20136    20208      +72     
- Partials     2594     2596       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov