Update docs links in /flyteidl #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2024 14:31
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4989 +/- ##
=======================================
Coverage 58.99% 59.00%
=======================================
Files 645 645
Lines 55542 55542
=======================================
+ Hits 32769 32770 +1
+ Misses 20182 20181 -1
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Mar 1, 2024
pingsutw
previously approved these changes
Mar 6, 2024
|
@pingsutw looks like this check is continuing to fail, although I've tried rerunning it a few times and merged master down into this branch. Should I go ahead and merge anyway? |
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
Mar 7, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
Signed-off-by: nikki everett <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Update docs links since they will break when we fully switch to new monodocs build process.
Check all the applicable boxes