Add gRPC probe for agent #4990
Add gRPC probe for agent #4990
Conversation
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4990 +/- ##
==========================================
- Coverage 58.99% 58.99% -0.01%
==========================================
Files 645 645
Lines 55547 55547
==========================================
- Hits 32772 32769 -3
- Misses 20183 20187 +4
+ Partials 2592 2591 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:S
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: Kevin Su <[email protected]>
|
I've checked 2 docs from k8s official website. |
|
Don't merge this PR, I am looking the bug |
charts/flyteagent/values.yaml
Outdated
| readinessProbe: | ||
| grpc: | ||
| port: 8000 | ||
| initialDelaySeconds: 5 |
There was a problem hiding this comment.
Why is it that high? or why is it needed?
There was a problem hiding this comment.
importing some python modules is very slow, especially airflow and spark.
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Tracking issue
#3936
Why are the changes needed?
Allow propeller to send the request only when agent is ready.
What changes were proposed in this pull request?
Add gRPC probe
How was this patch tested?
Sandbox
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Blocked by flyteorg/flytekit#2232 and flytekit release
Docs link
NA