Add Docker image build and FlyteAgent update steps to "Developing agents" doc #5009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2024 16:13
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:M
neverett
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5009 +/- ##
==========================================
+ Coverage 58.97% 59.00% +0.02%
==========================================
Files 645 645
Lines 55562 55542 -20
==========================================
+ Hits 32768 32770 +2
+ Misses 20199 20181 -18
+ Partials 2595 2591 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: nikki everett <[email protected]>
dosubot
bot
added
size:L
pingsutw
previously approved these changes
Mar 5, 2024
ppiegaze
previously approved these changes
Mar 6, 2024
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
Mar 6, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
…nts" doc (flyteorg#5009) * add docker image build and flyteagent update steps Signed-off-by: nikki everett <[email protected]> * fix link Signed-off-by: nikki everett <[email protected]> * remove old agents doc and redirect to new agents guide Signed-off-by: nikki everett <[email protected]> * update timeout Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: nikki everett <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds the "Build a new image" and "Update FlyteAgent" steps to the new "Developing agents" doc. Once those steps are copied in, I'll remove the old doc, since it's fairly outdated now.
Check all the applicable boxes
Docs link
TBD