Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow for helm charts and manifests #5027

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Mar 9, 2024

Tracking issue

Closes #4973

Why are the changes needed?

We should be serious about changes to helm charts and manifests, The current CI doesn't ensure manifests are valid against to the schema for Kubernetes.

What changes were proposed in this pull request?

  1. Create a new gha workflow to test helm charts if them are changed, and validate generated manifests.
  2. We can specify k8s versions that we want to ensure manifests are still valid for that k8s version. (avoiding some apiVersion of resource is deprecated but we don't notice that)

How was this patch tested?

Setup process

  1. Install nektos/act to test actions locally
  2. Create an json file called event.json, and copy & paste the following code into event.json
{
  "repository": {
    "default_branch": "master"
  }
}
  1. Run act pull_request -W .github/workflows/validate-helm-charts.yaml --container-architecture linux/amd64 -e <path to event.json file>

  2. The workflow will start. You can change any charts to trigger steps after Detect charts changed (list-changed) in lint-and-test-charts job.

  3. As for validate-manifests job, it will use kubeconform for validate manifests under deployments and docker/sandbox-bundled/manifests.

Screenshots

截圖 2024-03-09 晚上8 20 21

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Mar 9, 2024
lowc1012 added 5 commits March 9, 2024 15:44
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
@lowc1012
Copy link
Contributor Author

lowc1012 commented Mar 9, 2024

Could we remove deployment/xxx/xxxxx_generated.yaml generated by kustomize?
because it use outdated dependencies such as pytorch-operator
c.c @pingsutw

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.99%. Comparing base (fd42f65) to head (1f36148).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5027      +/-   ##
==========================================
- Coverage   58.99%   58.99%   -0.01%     
==========================================
  Files         645      645              
  Lines       55542    55548       +6     
==========================================
+ Hits        32769    32770       +1     
- Misses      20182    20187       +5     
  Partials     2591     2591              
Flag Coverage Δ
unittests 58.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 13, 2024
@pingsutw pingsutw merged commit 44914b1 into flyteorg:master Mar 13, 2024
48 of 49 checks passed
yubofredwang pushed a commit to yubofredwang/flyte that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Add kubeconform check to validate generated manifests in CI
2 participants