-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI workflow for helm charts and manifests #5027
Conversation
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Could we remove |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5027 +/- ##
==========================================
- Coverage 58.99% 58.99% -0.01%
==========================================
Files 645 645
Lines 55542 55548 +6
==========================================
+ Hits 32769 32770 +1
- Misses 20182 20187 +5
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
Tracking issue
Closes #4973
Why are the changes needed?
We should be serious about changes to helm charts and manifests, The current CI doesn't ensure manifests are valid against to the schema for Kubernetes.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
event.json
, and copy & paste the following code into event.jsonRun
act pull_request -W .github/workflows/validate-helm-charts.yaml --container-architecture linux/amd64 -e <path to event.json file>
The workflow will start. You can change any charts to trigger steps after
Detect charts changed (list-changed)
in lint-and-test-charts job.As for validate-manifests job, it will use
kubeconform
for validate manifests under deployments and docker/sandbox-bundled/manifests.Screenshots
Check all the applicable boxes
Related PRs
Docs link