Remove outdated kustomize deployment #5029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
Signed-off-by: Ryan Lo <[email protected]>
Signed-off-by: Ryan Lo <[email protected]>
lowc1012
force-pushed
the
remove-kustomize
branch
from
8c493f1 to
1732a9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5029 +/- ##
==========================================
+ Coverage 58.98% 59.00% +0.01%
==========================================
Files 645 645
Lines 55548 55548
==========================================
+ Hits 32764 32775 +11
+ Misses 20193 20182 -11
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Mar 11, 2024
eapolinario
approved these changes
Mar 11, 2024
3 tasks
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
* remove kustomize Signed-off-by: Ryan Lo <[email protected]> * update docs Signed-off-by: Ryan Lo <[email protected]> --------- Signed-off-by: Ryan Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
The manifests generated via Kustomize are outdated, and almost no one uses this deployment approach.
I think we just need to concentrate on maintenance for helm charts.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flytesnacks
flyteorg/flytesnacks#1545
Docs link