docs: improve documentation for overwriting existing images #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add instructions for overwriting an existing image using `FLYTE_FORCE_PUSH_IMAGE_SPEC=True` command - Provide code examples for overwriting an existing image using `pyflyte run` and `ImageSpec.force_push()` Signed-off-by: jason.lai <[email protected]>
dosubot
bot
added
size:S
3 tasks
pingsutw
reviewed
Mar 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5030 +/- ##
==========================================
+ Coverage 58.98% 59.00% +0.02%
==========================================
Files 645 645
Lines 55548 55548
==========================================
+ Hits 32764 32776 +12
+ Misses 20193 20181 -12
Partials 2591 2591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Update the instructions for forcing an image rebuild with `FLYTE_FORCE_PUSH_IMAGE_SPEC=True` passed to `pyflyte` command or `force_push()` added to the ImageSpec Signed-off-by: jason.lai <[email protected]>
- Update the code block language specifier to `python` Signed-off-by: jason.lai <[email protected]>
pingsutw
approved these changes
Mar 10, 2024
yubofredwang
pushed a commit
to yubofredwang/flyte
that referenced
this pull request
Mar 26, 2024
…#5030) Signed-off-by: jason.lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
FLYTE_FORCE_PUSH_IMAGE_SPEC=Truecommandpyflyte runandImageSpec.force_push()What changes were proposed in this pull request?
FORCE_PUSHfeature in ImageSpec fileHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytekit#2234
Docs link