Remove end2end.yml #5034
Merged
Remove end2end.yml #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
dosubot
bot
added
size:S
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5034 +/- ##
=======================================
Coverage 60.99% 60.99%
=======================================
Files 793 793
Lines 51350 51350
=======================================
Hits 31319 31319
Misses 17145 17145
Partials 2886 2886
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm 99% sure we don't use this workflow anywhere. Can you double-check and if that's the case, should we remove it? |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
|
@eapolinario I revive end2end test. It only runs when merging PRs since it takes 15 minutes. https://github.com/flyteorg/flyte/actions/runs/8967710966/job/24626449666?pr=5034 |
Signed-off-by: Kevin Su <[email protected]>
pingsutw
commented
May 6, 2024
| @click.option( | ||
| "--parallel", | ||
| is_flag=True, | ||
| default=False, |
There was a problem hiding this comment.
Run flytesnacks workflow serially by default in the CI due to disk pressure in the sandbox.
eapolinario
approved these changes
May 7, 2024
eapolinario
requested changes
May 8, 2024
pingsutw
commented
May 8, 2024
eapolinario
previously approved these changes
May 8, 2024
Signed-off-by: Kevin Su <[email protected]>
eapolinario
previously approved these changes
May 8, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
|
Just found that we already have end2end tests here, so we don't need |
pingsutw
changed the title
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Future-Outlier
approved these changes
Jun 16, 2024
eapolinario
approved these changes
Jun 16, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
vlibov
pushed a commit
to vlibov/flyte
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
What changes were proposed in this pull request?
We already have end2end tests here, so we don't need end2end.yml anymore
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
flyteorg/flytectl#462
Docs link