Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overwrite cache bug in UI #5038

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

update comments

f4ed505
Select commit
Loading
Failed to load commit list.
Open

fix overwrite cache bug in UI #5038

update comments
f4ed505
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 18, 2024 in 0s

57.07% (-1.93%) compared to 1d2e305

View this Pull Request on Codecov

57.07% (-1.93%) compared to 1d2e305

Details

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 57.07%. Comparing base (1d2e305) to head (f4ed505).
Report is 12 commits behind head on master.

Files Patch % Lines
flyteadmin/pkg/manager/impl/execution_manager.go 57.89% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5038      +/-   ##
==========================================
- Coverage   59.00%   57.07%   -1.93%     
==========================================
  Files         645      364     -281     
  Lines       55578    34630   -20948     
==========================================
- Hits        32792    19765   -13027     
+ Misses      20194    13208    -6986     
+ Partials     2592     1657     -935     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.