Add support for generic dynamic log links #5066
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#4773
Why are the changes needed?
We need support for dynamic log links defined by tasks.
What changes were proposed in this pull request?
Add a flag to the propeller config called
GenericDynamicLogLinksEnabled
, which is self-explanatory. We then use a dynamic log link guard called "Generic" to guide the addition of generic dynamic log links (what I'm calling these log links defined in tasks - a better name could be in order).How was this patch tested?
Unit tests and local sandbox.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link