Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generic dynamic log links #5066

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

eapolinario
Copy link
Contributor

Tracking issue

#4773

Why are the changes needed?

We need support for dynamic log links defined by tasks.

What changes were proposed in this pull request?

Add a flag to the propeller config called GenericDynamicLogLinksEnabled, which is self-explanatory. We then use a dynamic log link guard called "Generic" to guide the addition of generic dynamic log links (what I'm calling these log links defined in tasks - a better name could be in order).

How was this patch tested?

Unit tests and local sandbox.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 59.01%. Comparing base (44914b1) to head (a038831).
Report is 5 commits behind head on master.

Files Patch % Lines
...ugins/go/tasks/pluginmachinery/tasklog/template.go 77.27% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5066      +/-   ##
==========================================
+ Coverage   59.00%   59.01%   +0.01%     
==========================================
  Files         645      645              
  Lines       55578    55622      +44     
==========================================
+ Hits        32792    32826      +34     
- Misses      20194    20201       +7     
- Partials     2592     2595       +3     
Flag Coverage Δ
unittests 59.01% <81.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant